Automated static analysis, commonly referred to as Static Application Security Testing (SAST), can find some instances of this weakness by analyzing source code (or binary/compiled code) without having to execute it. Typically, this is done by building a model of data flow and control flow, then searching for potentially-vulnerable patterns that connect "sources" (origins of input) with "sinks" (destinations where the data interacts with external components, a lower layer such as the OS, etc.)
CWE-838 Base Incomplete
Inappropriate Encoding for Output Context
This vulnerability occurs when a system uses one type of encoding for its output, but the component receiving that data expects a different encoding. The mismatch causes the downstream component to…
Definition
What is CWE-838?
This vulnerability occurs when a system uses one type of encoding for its output, but the component receiving that data expects a different encoding. The mismatch causes the downstream component to interpret the data incorrectly.
When the wrong encoding is applied, even if it's similar to the correct one, the receiving component may decode characters into unexpected control commands or special elements. This breaks the intended separation between data and executable instructions, potentially allowing injection attacks to bypass security checks like input validation.
While common in web security—like using HTML entity encoding in a JavaScript context where it's ineffective—this issue can affect any system where data passes between components using different encoding rules. The core problem isn't a lack of encoding, but using encoding that doesn't match the context in which the data will be interpreted.
Auswirkungen in der Praxis
Real-world CVEs caused by CWE-838
-
Server does not properly handle requests that do not contain UTF-8 data; browser assumes UTF-8, allowing XSS.
Wie Angreifer es ausnutzen
Angreiferpfad Schritt für Schritt
- 1
This code dynamically builds an HTML page using POST data:
- 2
The programmer attempts to avoid XSS exploits (CWE-79) by encoding the POST values so they will not be interpreted as valid HTML. However, the htmlentities() encoding is not appropriate when the data are used as HTML attributes, allowing more attributes to be injected.
- 3
For example, an attacker can set picAltText to:
- 4
This will result in the generated HTML image tag:
- 5
The attacker can inject arbitrary javascript into the tag due to this incorrect encoding.
Verwundbares Codebeispiel
Vulnerable PHP
This code dynamically builds an HTML page using POST data:
$username = $_POST['username'];
$picSource = $_POST['picsource'];
$picAltText = $_POST['picalttext'];
```
...*
echo "<title>Welcome, " . htmlentities($username) ."</title>";
echo "<img src='". htmlentities($picSource) ." ' alt='". htmlentities($picAltText) . '" />';
*...* Angreifer-Payload
For example, an attacker can set picAltText to:
"altTextHere' onload='alert(document.cookie)" Sicheres Codebeispiel
Secure pseudo
// Validate, sanitize, or use a safe API before reaching the sink.
function handleRequest(input) {
const safe = validateAndEscape(input);
return executeWithGuards(safe);
} What changed: the unsafe sink is replaced (or the input is validated/escaped) so the same payload no longer triggers the weakness.
Präventions-Checkliste
How to prevent CWE-838
- Implementation Use context-aware encoding. That is, understand which encoding is being used by the downstream component, and ensure that this encoding is used. If an encoding can be specified, do so, instead of assuming that the default encoding is the same as the default being assumed by the downstream component.
- Architecture and Design Where possible, use communications protocols or data formats that provide strict boundaries between control and data. If this is not feasible, ensure that the protocols or formats allow the communicating components to explicitly state which encoding/decoding method is being used. Some template frameworks provide built-in support.
- Architecture and Design Use a vetted library or framework that does not allow this weakness to occur or provides constructs that make this weakness easier to avoid. For example, consider using the ESAPI Encoding control [REF-45] or a similar tool, library, or framework. These will help the programmer encode outputs in a manner less prone to error. Note that some template mechanisms provide built-in support for the appropriate encoding.
Erkennungssignale
How to detect CWE-838
CWE-838
Don't catalog this weakness. Prove it's reachable.
Plexicus turns CWE catalogs into evidence: every CWE-pattern is matched against your real code graph, reach is proven on a sandbox clone, and verified findings ship as reviewed PRs.
Häufig gestellte Fragen Was ist CWE-838?
Wie gravierend ist CWE-838?
Welche Sprachen oder Plattformen sind von CWE-838 betroffen?
Wie kann ich CWE-838 verhindern?
Wie erkennt und behebt Plexicus CWE-838?
Wo erfahre ich mehr über CWE-838?
Frequently asked questions
Was ist CWE-838?
This vulnerability occurs when a system uses one type of encoding for its output, but the component receiving that data expects a different encoding. The mismatch causes the downstream component to interpret the data incorrectly.
Wie gravierend ist CWE-838?
MITRE hat für diese Schwachstelle keine Exploit-Wahrscheinlichkeit veröffentlicht. Behandle sie als mittlere Auswirkung, bis dein Threat Model anderes belegt.
Welche Sprachen oder Plattformen sind von CWE-838 betroffen?
MITRE hat für diese CWE keine betroffenen Plattformen spezifiziert — sie kann in den meisten Anwendungs-Stacks auftreten.
Wie kann ich CWE-838 verhindern?
Use context-aware encoding. That is, understand which encoding is being used by the downstream component, and ensure that this encoding is used. If an encoding can be specified, do so, instead of assuming that the default encoding is the same as the default being assumed by the downstream component. Where possible, use communications protocols or data formats that provide strict boundaries between control and data. If this is not feasible, ensure that the protocols or formats allow the…
Wie erkennt und behebt Plexicus CWE-838?
Die SAST-Engine von Plexicus erkennt die Datenfluss-Signatur von CWE-838 bei jedem Commit. Bei einem Treffer öffnet unser Codex-Remedium-Agent einen Fix-PR mit korrigiertem Code, Tests und einer einzeiligen Zusammenfassung für den Reviewer.
Wo erfahre ich mehr über CWE-838?
MITRE veröffentlicht die kanonische Definition unter https://cwe.mitre.org/data/definitions/838.html. Für ergänzende Hinweise kannst du auch die OWASP- und NIST-Dokumentation heranziehen.
Verwandte Schwachstellen
Weaknesses related to CWE-838
CWE-116 Parent
Improper Encoding or Escaping of Output
This vulnerability occurs when an application builds a structured message—like a query, command, or request—for another component but…
CWE-117 Sibling
Improper Output Neutralization for Logs
This vulnerability occurs when an application creates log entries using unvalidated external data, allowing attackers to inject malicious…
CWE-644 Sibling
Improper Neutralization of HTTP Headers for Scripting Syntax
This vulnerability occurs when an application fails to properly sanitize or escape user-controlled data placed within HTTP response…
Ressourcen
Further reading
- MITRE — offizielle CWE-838 https://cwe.mitre.org/data/definitions/838.html
- Injection-safe templating languages https://manicode.blogspot.com/2010/06/injection-safe-templating-languages_30.html
- Can we please stop saying that XSS is boring and easy to fix! http://diniscruz.blogspot.com/2010/09/can-we-please-stop-saying-that-xss-is.html
- Canoe: XSS prevention via context-aware output encoding https://blog.ivanristic.com/2010/09/introducing-canoe-context-aware-output-encoding-for-xss-prevention.html
- What is the Future of Automated XSS Defense Tools? http://software-security.sans.org/downloads/appsec-2011-files/manico-appsec-future-tools.pdf
- DOM based XSS Prevention Cheat Sheet http://www.owasp.org/index.php/DOM_based_XSS_Prevention_Cheat_Sheet
Bereit, das Wesentliche zu validieren?
Bereit zu validieren, was zählt.
Plexicus ist Proof-Driven AppSec: validierte Funde, kontextuelles Verständnis und geprüfte Remediation — in Evidenz verankert, mit Ihnen gescoped.