Public Static Final Field References Mutable Object

Draft Variant

Structure: Simple

Description

A public or protected static final field references a mutable object, which allows the object to be changed by malicious code, or accidentally from another package.

Common Consequences 1

Scope: Integrity

Impact: Modify Application Data

Detection Methods 1

Automated Static AnalysisHigh

Automated static analysis, commonly referred to as Static Application Security Testing (SAST), can find some instances of this weakness by analyzing source code (or binary/compiled code) without having to execute it. Typically, this is done by building a model of data flow and control flow, then searching for potentially-vulnerable patterns that connect "sources" (origins of input) with "sinks" (destinations where the data interacts with external components, a lower layer such as the OS, etc.)

Potential Mitigations 1

Phase: Implementation

Protect mutable objects by making them private. Restrict access to the getter and setter as well.

Demonstrative Examples 1

Here, an array (which is inherently mutable) is labeled public static final.

Code Example:Bad
Java
java

Applicable Platforms

Languages:

Java : Undetermined

Modes of Introduction

Implementation

Related Weaknesses

ChildOf:

Modification of Assumed-Immutable Data (MAID) (CWE-471)

Taxonomy Mapping

Software Fault Patterns