Insufficient Encapsulation
Incomplete Class
Structure: Simple
Description
The product does not sufficiently hide the internal representation and implementation details of data or methods, which might allow external components or modules to modify data unexpectedly, invoke unexpected functionality, or introduce dependencies that the programmer did not intend.
This issue makes it more difficult to maintain the product, which indirectly affects security by making it more difficult or time-consuming to find and/or fix vulnerabilities. It also might make it easier to introduce vulnerabilities.
Demonstrative Examples 1
ID : DX-212
The following example shows a basic user account class that includes member variables for the username and password as well as a public constructor for the class and a public method to authorize access to the user account.Code Example:
Bad
C++
c++// if the username and password in the input parameters are equal to*
c++c++However, the member variables username and password are declared public and therefore will allow access and changes to the member variables to anyone with access to the object. These member variables should be declared private as shown below to prevent unauthorized access and changes.
Code Example:
Good
C++
c++Observed Examples 1
CVE-2010-3860variables declared public allow remote read of system properties such as user name and home directory.
References 1
Encapsulation (computer programming)
Wikipedia
ID: REF-969
Related Weaknesses