Use of Redundant Code
Incomplete Base
Structure: Simple
Description
The product has multiple functions, methods, procedures, macros, etc. that contain the same code.
This issue makes it more difficult to maintain the product, which indirectly affects security by making it more difficult or time-consuming to find and/or fix vulnerabilities. For example, if there are two copies of the same code, the programmer might fix a weakness in one copy while forgetting to fix the same weakness in another copy.
Common Consequences 1
Scope: Other
Impact: Reduce Maintainability
Potential Mitigations 1
Phase: Implementation
Merge common functionality into a single function and then call that function from across the entire code base.
Demonstrative Examples 1
In the following Java example the code performs some complex math when specific test conditions are met. The math is the same in each case and the equations are repeated within the code. Unfortunately if a future change needs to be made then that change needs to be made in all locations. This opens the door to mistakes being made and the changes not being made in the same way in each instance.
Code Example:
Bad
Java
javaIt is recommended to place the complex math into its own function and then call that function whenever necessary.
Code Example:
Good
Java
javaReferences 1
Automated Source Code Maintainability Measure (ASCMM)
Object Management Group (OMG)
01-2016
https://www.omg.org/spec/ASCMM/(2023-04-07)
ID: REF-960
Applicable Platforms
Languages:
Not Language-Specific : Undetermined
Related Weaknesses
Taxonomy Mapping
- OMG ASCMM